Update package name used in test folders - Asset runner

[mrodm]

This PR updates the package strings set for the TestFolders in the Asset Runner/Tester to be the same as in the other tests (policy, system, static and pipeline).

This mainly affects those packages whose folder name is different of the name specified in their manfiest.yml.

This package name is used in the xUnit reports and it can be seen the difference in those values for the asset tests classname attribute:

• Before
  • Asset

  <testsuites>
    <testsuite name="asset" tests="29">
    <!-- test suite for asset tests -->
      <testcase name="asset test: dashboard apache-Logs-Apache-Dashboard is loaded" classname="apache." time="1.979e-06"/>
      <testcase name="asset test: dashboard apache-Metrics-Apache-HTTPD-server-status is loaded" classname="apache." time="5.8e-07"/>
      ...
    </testsuite>
  </testsuites>

  • Static

  <testsuites>
    <testsuite name="static" tests="3">
    <!-- test suite for static tests -->
      <testcase name="static test: Verify sample_event.json" classname="apache_basic_license.access" time="0.115197493"/>
      <testcase name="static test: Verify sample_event.json" classname="apache_basic_license.error" time="0.100131448"/>
      <testcase name="static test: Verify sample_event.json" classname="apache_basic_license.status" time="0.079474684"/>
    </testsuite>
  </testsuites>

• After
  • Asset

    <testsuites>
      <testsuite name="pipeline" tests="18">
        <!--test suite for pipeline tests-->
        <testcase name="pipeline test: (ingest pipeline warnings test-access-basic.log)" classname="apache_basic_license.access" time="0.298683383"></testcase>
        <testcase name="pipeline test: (ingest pipeline warnings test-access-darwin.log)" classname="apache_basic_license.access" time="0.329030781"></testcase>
        ...
      </testsuite>
    </testsuites>

  • Static

    <testsuites>
      <testsuite name="static" tests="3">
        <!--test suite for static tests-->
        <testcase name="static test: Verify sample_event.json" classname="apache_basic_license.access" time="0.081731747"></testcase>
        <testcase name="static test: Verify sample_event.json" classname="apache_basic_license.error" time="0.059626114"></testcase>
        <testcase name="static test: Verify sample_event.json" classname="apache_basic_license.status" time="0.052784676"></testcase>
      </testsuite>
    </testsuites>

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 1986570

cc @mrodm

[mrodm]

Same change that it is applied in other test runners or testers:

elastic-package/internal/testrunner/testrunner.go

Lines 232 to 238 in ef09037

	for _, dataStream := range dataStreams {
	folders = append(folders, TestFolder{
	Path: filepath.Join(dataStreamsPath, dataStream, "_dev", "test", string(testType)),
	Package: filepath.Base(packageRootPath),
	DataStream: dataStream,
	})
	}

elastic-package/internal/testrunner/testrunner.go

Lines 293 to 304 in ef09037

	_, pkg := filepath.Split(packageRootPath)
	for idx, p := range paths {
	dataStream := ExtractDataStreamFromPath(p, packageRootPath)
	folder := TestFolder{
	Path: p,
	Package: pkg,
	DataStream: dataStream,
	}
	folders[idx] = folder
	}

[mrodm]

installedPackage.Name is the name set in the manifest.yml , but this could be different from the package folder name. As it happens, for instance, with the sql_input package in the integrations repository (link):

• Folder name: sql_input
• Package name in the manifest: sql

[jsoriano]

Ideally we should use the name in the manifest as package name, but I see the inconveniences.

Maybe at some point we can have both values, the name in the manifest, and the path information.