Skip to content

Update help message for benchmark command #2585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025
Merged

Update help message for benchmark command #2585

merged 2 commits into from
Jun 13, 2025

Conversation

philippkahr
Copy link
Contributor

@philippkahr philippkahr commented May 9, 2025

Formatting is weird when not wrapped in code block, we can also do a list

image

Formatting is weird when not wrapped in code block
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 9, 2025

💔 Build Failed

Failed CI Steps

History

Comment on lines +190 to +195
```
ELASTIC_PACKAGE_ELASTICSEARCH_HOST=https://my-deployment.es.eu-central-1.aws.foundit.no
ELASTIC_PACKAGE_ELASTICSEARCH_USERNAME=elastic
ELASTIC_PACKAGE_ELASTICSEARCH_PASSWORD=changeme
ELASTIC_PACKAGE_KIBANA_HOST=https://my-deployment.kb.eu-central-1.aws.foundit.no:9243
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @philippkahr,

This README file is generated automatically. In order to CI not fail because of that, you should update also this file:

#### Stream Benchmarks
These benchmarks allow you to benchmark ingesting real time data.
You can stream data to a remote ES cluster setting the following environment variables:
ELASTIC_PACKAGE_ELASTICSEARCH_HOST=https://my-deployment.es.eu-central-1.aws.foundit.no
ELASTIC_PACKAGE_ELASTICSEARCH_USERNAME=elastic
ELASTIC_PACKAGE_ELASTICSEARCH_PASSWORD=changeme
ELASTIC_PACKAGE_KIBANA_HOST=https://my-deployment.kb.eu-central-1.aws.foundit.no:9243

That is one of the files that are taken as a source to generate the main README.md

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in f1a30f1

@mrodm mrodm requested a review from a team May 23, 2025 08:27
@mrodm mrodm reopened this Jun 13, 2025
@mrodm
Copy link
Contributor

mrodm commented Jun 13, 2025

/test

@mrodm mrodm changed the title Update README Update help message for benchmark command Jun 13, 2025
@mrodm mrodm merged commit 08a4310 into main Jun 13, 2025
3 checks passed
@mrodm mrodm deleted the philippkahr-patch-1 branch June 13, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants