-
Notifications
You must be signed in to change notification settings - Fork 126
Add test package with docker service deployers using terraform too #2670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0727bee
to
7155d5c
Compare
# Example to use credentials | ||
- AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID} | ||
- AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY} | ||
- AWS_SESSION_TOKEN=${AWS_SESSION_TOKEN} | ||
- AWS_PROFILE=${AWS_PROFILE} | ||
- AWS_REGION=${AWS_REGION:-us-east-1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add these environment variables as example here too?
I haven't tested if that works, but probably it works.
If it is required to create resources in AWS, probably they should use the terraform deployer. WDYT ? To remove it from the example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we can remove them by now, and added later if requested.
@@ -69,7 +69,7 @@ or the data stream's level: | |||
|
|||
`<service deployer>` - a name of the supported service deployer: | |||
* `docker` - Docker Compose | |||
* `agent` - Custom `elastic-agent` with Docker Compose | |||
* `agent` - (Deprecated) Custom `elastic-agent` with Docker Compose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could remove support for agent
deployer based on some package spec version, maybe 3.5. Do you know if we have an open issue for the removal of this deployer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK there is no issue for that.
Just created a new one #2679
# Example to use credentials | ||
- AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID} | ||
- AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY} | ||
- AWS_SESSION_TOKEN=${AWS_SESSION_TOKEN} | ||
- AWS_PROFILE=${AWS_PROFILE} | ||
- AWS_REGION=${AWS_REGION:-us-east-1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we can remove them by now, and added later if requested.
docs/howto/system_testing.md
Outdated
@@ -110,6 +110,63 @@ volumes: | |||
mysqldata: | |||
``` | |||
|
|||
#### Run terraform along with the Docker Compose service deployer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can explain that this is an example of running a custom provisioner, and not something with special support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 191b9c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some rephrasing proposed.
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
💚 Build Succeeded
History
cc @mrodm |
Relates #1302
Add a new test package as example to run terraform using the Docker Compose Service deployer.
Using that test package as a base, the documentation about system testing has been updated to explain this scenario.
As a note, it has been added in the docker compose service deployer a new placeholder to use
TEST_RUN_ID
created internally byelastic-package
as environment variable in the docker-compose.