-
Notifications
You must be signed in to change notification settings - Fork 126
Add docs about package types #2691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
Just added some minor comments.
|
||
For legacy reasons, integration packages can be used for most use cases. For | ||
example a package can include dashboards without including any data stream, as | ||
if it were a content package. Or an integration package can define a single data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it were a content package. Or an integration package can define a single data | |
if it was a content package. Or an integration package can define a single data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think were is correct here 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmm now I have doubts 😅
Probably, you're right and it should be as if it were
... as an hypothetical situation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Native English speaker here 👋 - both sound fine imo. Terrible language 😜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 😄
Add description for package types and how to chose between them.