Revisit elastic-package test command output #2756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
commented
Jul 23, 2025
Comment on lines
-60
to
-63
| err := os.RemoveAll(options.Output) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("can't remove output location: %w", err) | ||
| } |
There was a problem hiding this comment.
Moved this remove call to the if checking if options.Output is not an empty string.
mrodm
commented
Jul 23, 2025
| @@ -56,12 +60,6 @@ func Dump(ctx context.Context, options DumpOptions) ([]DumpResult, error) { | |||
| } | |||
|
|
|||
| func dumpStackLogs(ctx context.Context, options DumpOptions) ([]DumpResult, error) { | |||
| logger.Debugf("Dump stack logs (location: %s)", options.Output) | |||
There was a problem hiding this comment.
Remove this message in favor of the one in Dump()
|
test serverless |
|
Triggered serverless pipeline: https://buildkite.com/elastic/elastic-package-test-serverless/builds/496 |
|
test serverless |
mrodm
commented
Jul 24, 2025
| @@ -57,7 +57,6 @@ func NewClient(opts ...ClientOption) (*Client, error) { | |||
| if host != "" { | |||
| c.host = host | |||
| } | |||
| logger.Debugf("Using Elastic Cloud URL: %s", c.host) | |||
There was a problem hiding this comment.
I think this message is not needed. WDYT ?
Another option is move that message to Trace log level.
|
Triggered serverless pipeline: https://buildkite.com/elastic/elastic-package-test-serverless/builds/497 |
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @mrodm |
jsoriano
approved these changes
Jul 24, 2025
This was referenced Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #1903
This PR reviews the output shown by the
elastic-package testcommand. Mainly focused ontest systemExample of output with verbose mode: https://buildkite.com/elastic/elastic-package/builds/5726#0198319b-a5a9-4464-b193-cdbaf0bbd898/253-614
Example of output without verbose mode:
Author's Checklist