Skip to content

[updatecli] Update default stack version to 9.0.4 #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 25, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Bump elastic-stack default version

[updatecli] Update default stack version to 9.0.4

1 file(s) updated with "$1 \"9.0.4\"": * internal/install/stack_version.go

GitHub Action workflow link
Updatecli logo

Created automatically by Updatecli

Options:

Most of Updatecli configuration is done via its manifest(s).

  • If you close this pull request, Updatecli will automatically reopen it, the next time it runs.
  • If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.

Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!

@github-actions github-actions bot requested a review from a team as a code owner July 23, 2025 01:29
@mrodm
Copy link
Contributor

mrodm commented Jul 23, 2025

The issue with Custom Agents (Deprecated) should be fixed in #2761 (with-custom and system-flags steps).
Issues related to system_benchmark package should be fixed in #2762 (with-logstash and benchmarks steps)

There are still other issues in other test packages cc @jsoriano

@mrodm
Copy link
Contributor

mrodm commented Jul 23, 2025

Other errors in ti_anomali, ti_anomali_logsdb and auth0_logsdb packages are related to the errors mentioned in elastic/integrations#14022

test case failed: one or more errors found while examining elastic-agent.logs309812572: [0] found error "Unit state changed http_endpoint-default-http_endpoint-ti_anomali-e01bca37-c5d4-46a2-a349-42efb9b0a49c (HEALTHY->DEGRADED): request did not validate: only POST requests are allowed"

but AFAIK there is no solution to solve those yet.

package_name=$(basename "${package}")
echo " - label: \":go: Integration test (with logstash): ${package_name}\""
echo " key: \"integration-with_logstash-${package_name}\""
echo " command: ./.buildkite/scripts/integration_tests.sh -t test-check-packages-with-logstash -p ${package_name}"
Copy link
Contributor

@mrodm mrodm Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realised that this if needs to be updated in order to trigger each package independently @jsoriano :

if [[ "${TARGET}" == "${PARALLEL_TARGET}" ]] || [[ "${TARGET}" == "${FALSE_POSITIVES_TARGET}" ]]; then

Or try to check different this condition

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like this could be done ? WDYT?

diff --git .buildkite/scripts/integration_tests.sh .buildkite/scripts/integration_tests.sh
index c84889ce..b2db2b23 100755
--- .buildkite/scripts/integration_tests.sh
+++ .buildkite/scripts/integration_tests.sh
@@ -15,10 +15,17 @@ usage() {
 
 PARALLEL_TARGET="test-check-packages-parallel"
 FALSE_POSITIVES_TARGET="test-check-packages-false-positives"
+LOGSTASH_TARGET="test-check-packages-with-logstash"
 KIND_TARGET="test-check-packages-with-kind"
 SYSTEM_TEST_FLAGS_TARGET="test-system-test-flags"
 TEST_BUILD_ZIP_TARGET="test-build-zip"
 
+TEST_EACH_PACKAGE_TARGETS=(
+    "${PARALLEL_TARGET}"
+    "${FALSE_POSITIVES_TARGET}"
+    "${LOGSTASH_TARGET}"
+)
+
 REPO_NAME=$(repo_name "${BUILDKITE_REPO}")
 export REPO_BUILD_TAG="${REPO_NAME}/$(buildkite_pr_branch_build_id)"
 TARGET=""
@@ -89,7 +96,15 @@ if [ -n "${PACKAGE}" ]; then
     label="${label} - ${PACKAGE}"
 fi
 echo "--- Run integration test ${label}"
-if [[ "${TARGET}" == "${PARALLEL_TARGET}" ]] || [[ "${TARGET}" == "${FALSE_POSITIVES_TARGET}" ]]; then
+test_each_package=false
+for target in "${TEST_EACH_PACKAGE_TARGETS[@]}"; do
+    if [[ "${TARGET}" == "${target}" ]]; then
+        test_each_package=true
+        break
+    fi
+done
+
+if [[ "${test_each_package}" == "true" ]]; then
     make install
 
     # allow to fail this command, to be able to upload safe logs

Copy link
Contributor

@mrodm mrodm Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe it can be revisited that if and try to unify both branches of that if statement into just one.

echo "--- Run integration test ${label}"

# allow to fail this command, to be able to upload safe logs
set +e
make SERVERLESS="${SERVERLESS}" PACKAGE_UNDER_TEST="${PACKAGE}" "${TARGET}"
testReturnCode=$?
set -e

if [[ "${UPLOAD_SAFE_LOGS}" -eq 1 ]] ; then
    # upload safe logs code ...
fi

if [ $testReturnCode != 0 ]; then
    echo "make SERVERLESS=${SERVERLESS} PACKAGE_UNDER_TEST=${PACKAGE} ${TARGET} failed with ${testReturnCode}"
    exit ${testReturnCode}
fi

echo "--- Check git clean"
make check-git-clean
exit 0

PACKAGE_UNDER_TEST variable should be empty string in the other Makefile targets, and SERVERLESS should be just true in its corresponding pipeline. But this needs to be tested...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing in this PR #2768 the refactor/change proposed above

For this PR maybe it could be added another condition to the if to allow test-check-packages-with-logstash target too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying something like this in fc9cd80

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it fails due to a missing variable JOB_GCS_BUCKET_INTERNAL.
I think that variable can always be defined like this: d214271
No need to define it just in those specific steps.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it fail only for logstash? Should this be set in integration_tests.sh?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because steps testing logstash have another id/key name that do not match with the current conditions:

is_step_required_to_upload_safe_logs() {
if [[ "$BUILDKITE_PIPELINE_SLUG" != "elastic-package" && "$BUILDKITE_PIPELINE_SLUG" != "elastic-package-test-serverless" ]]; then
return 1
fi
if [[ "$BUILDKITE_PIPELINE_SLUG" == "elastic-package" ]]; then
if [[ "$BUILDKITE_STEP_KEY" =~ ^integration-parallel || "$BUILDKITE_STEP_KEY" =~ ^integration-false_positives ]]; then
return 0
fi
fi
if [[ "$BUILDKITE_PIPELINE_SLUG" == "elastic-package-test-serverless" ]]; then
if [[ "$BUILDKITE_STEP_KEY" == "test-serverless" ]]; then
return 0
fi
fi
return 1
}

I'd remove that function and set JOB_GCS_BUCKET_INTERNAL unconditionally.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove that function and set JOB_GCS_BUCKET_INTERNAL unconditionally.

Done like this.

@github-actions github-actions bot force-pushed the updatecli_main_bump-elastic-stack-default-version branch from b6839cd to 778b52c Compare July 24, 2025 01:29
@mrodm
Copy link
Contributor

mrodm commented Jul 24, 2025

/test

@jsoriano jsoriano force-pushed the updatecli_main_bump-elastic-stack-default-version branch from 5987d42 to b6839cd Compare July 24, 2025 18:56
@elasticmachine
Copy link
Collaborator

💔 Build Failed

Failed CI Steps

History

@jsoriano jsoriano enabled auto-merge (squash) July 24, 2025 20:31
@jsoriano jsoriano merged commit 07ffe0b into main Jul 25, 2025
3 checks passed
@jsoriano jsoriano deleted the updatecli_main_bump-elastic-stack-default-version branch July 25, 2025 10:39
@jsoriano
Copy link
Member

Created follow up issue to revert the pinned versions at some point #2773.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants