[CI] Refactor script to check and test packages in CI #2766
Conversation
mrodm
changed the title
| if [ "${package_to_test}" == "pipeline_benchmark" ]; then | ||
| rm -rf "${PWD}/build/benchmark-results" | ||
| elastic-package benchmark pipeline -C "$d" -v --report-format xUnit --report-output file --fail-on-missing | ||
| # FIXME: There are other packages in test/packages/benchmarks folder that are not tested like rally_benchmark |
There was a problem hiding this comment.
rally_benchmark package is located in test/packages/benchmarks folder but it is not tested at all.
I don't know if this could be tested as it is here. IIUC according to the docs it is required also esrally tool.
|
test serverless |
|
Triggered serverless pipeline: https://buildkite.com/elastic/elastic-package-test-serverless/builds/488 |
| pipeline_benchmark|use_pipeline_tests) | ||
| run_pipeline_benchmark "${package_to_test}" "$d" | ||
| ;; |
There was a problem hiding this comment.
Until now just pipeline_benchmark package was tested, other packages under test/packages/benchmarks/ folder were not tested. One of them is use_pipeline_tests package.
The difference that I see between pipeline_benchmark and use_pipeline_tests is that:
pipeline_benchmarkhas the benchmark configuration for the data stream atdata_stream/test/_dev/benchmark/pipeline/*.use_pipeline_testsno benchmark configuration.
Tested locally with use_pipeline_tests package and it does not fail running the pipeline benchmarks and it creates a benchmark report successfully.
I think it can be added here, WDYT ?
|
/test |
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
|
test serverless |
💔 Build Failed
Failed CI StepsHistory
cc @mrodm |
|
Triggered serverless pipeline: https://buildkite.com/elastic/elastic-package-test-serverless/builds/493 |
This PR applies a refactor in
scripts/test-check-packages.shscript to allow understand better the for loop that test all packages.Author's checklist
use_pipeline_testsis also part of thebenchmarksstep.