Skip to content

Add event.provider to API events #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

Conversation

gabriellandau
Copy link
Contributor

Change Summary

Add event.provider to API events to fix the issue reported in #630

For mapping changes:

  • I ran make after making the schema changes, and committed all changes
  • If these field(s) are "exception"-able, I made a companion PR to Kibana adding it (see Readme)

Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍 no tests needed ?

@gabriellandau
Copy link
Contributor Author

It's already in the sample document. Should we be doing additional testing?

"provider": "Microsoft-Windows-Threat-Intelligence",

@pzl
Copy link
Member

pzl commented May 28, 2025

It's already in the sample document. Should we be doing additional testing?

I'm not sure this repo consumes any of the test files under schemas/ (but I could be wrong). But I know that the automated testing in this repo (incl. CI in PRs) use these files to validate schemas:

package/endpoint/data_stream/<stream name>/sample_event.json

if you can add a value there, this PR should be good to go

@gabriellandau
Copy link
Contributor Author

Okay, thanks. It looks like we're already covered:

"provider": "Microsoft-Windows-Threat-Intelligence",

@gabriellandau gabriellandau merged commit 3dee0fb into main May 29, 2025
4 checks passed
@gabriellandau gabriellandau deleted the map-api-event-provider branch May 29, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants