-
Notifications
You must be signed in to change notification settings - Fork 19
Add new policy fields for firewall_anti_tamper plugin #637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the descriptions doesn't look good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add sample values for these new fields to package/endpoint/data_stream/policy/sample_event.json
?
custom_schemas/custom_endpoint.yml
Outdated
the overall status of firewall anti-tamper, this is correlated to the status of concerned actions | ||
but not a simple sum of the actions | ||
short: the overall status of firewall anti-tamper | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also add the example
field to these definitions. It's useful for enhancing the auto generated docs (see: #606)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. All of the fields for existing plugins are currently in the same format (eg here) so I copied these for consistency. Perhaps a separate PR could be raised to add the example
field to all of them at once?
Change Summary
Add additional Policy field entries for new
firewall_anti_tamper
plugin.For mapping changes:
make
after making the schema changes, and committed all changesmetadata
change, I also updated both transform destination schemas to matchFor Transform changes: