Skip to content

fix(website): update the button icon to align with the guideline #8901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

weronikaolejniczak
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak commented Jul 23, 2025

Summary

Resolve #8855

The guideline example on the Button page didn't align with what the guideline said.

Why are we making this change?

We are making this change because the current example goes against the guideline:

Stick to the default pattern: a filled, primary button paired with an empty, but same-colored button.

EuiButton uses color primary and EuiButtonIcon uses color danger.

We settled with the designers on changing the icon to gear and color to primary.

Screenshots

Before After
Screenshot 2025-07-23 at 11 00 53 Screenshot 2025-07-23 at 10 59 19

Impact to users

🟢 Affects our documentation website. It's not a breaking change.

QA

@weronikaolejniczak weronikaolejniczak requested a review from a team as a code owner July 23, 2025 09:05
@weronikaolejniczak weronikaolejniczak added the support-duty-flywheel Label for PRs, see eui-private #310 label Jul 23, 2025
@weronikaolejniczak weronikaolejniczak self-assigned this Jul 23, 2025
@weronikaolejniczak weronikaolejniczak added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Jul 23, 2025
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @weronikaolejniczak

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @weronikaolejniczak

Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 LGTM

@weronikaolejniczak weronikaolejniczak merged commit 0340fd5 into elastic:main Jul 25, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) support-duty-flywheel Label for PRs, see eui-private #310
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EUI Docs - Button example mismatch with description
3 participants