-
Notifications
You must be signed in to change notification settings - Fork 472
[PANW] Add conditional to processors populating _temp_ fields for internal and external zones #14671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PANW] Add conditional to processors populating _temp_ fields for internal and external zones #14671
Conversation
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me, just a suggestion to use ignore_empty_value
instead of an if statement.
packages/panw/data_stream/panos/elasticsearch/ingest_pipeline/traffic.yml
Show resolved
Hide resolved
packages/panw/data_stream/panos/elasticsearch/ingest_pipeline/traffic.yml
Show resolved
Hide resolved
/test |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
|
Package panw - 5.3.2 containing this change is available at https://epr.elastic.co/package/panw/5.3.2/ |
Proposed commit message
The first 2 processors in the logic to populate the field
network.direction
relies on the existence of the fields_conf.internal_zones
and_conf.external_zones
if the user does not configure those fields in the integration, or if the source data does not have this field, those processors would still try to process every message and would fail because the field does not exist, this can add some extra time in the overall processing time of the ingest pipeline.These 2 processors needs to be conditionally executed to avoid this, we detected this issue while troubleshooting the performance of the ingest pipeline.