Skip to content

[a11y] Fix Title announcement, image flyout dashboards #220027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2025
Merged

[a11y] Fix Title announcement, image flyout dashboards #220027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3c5d87
[a11y] Fix Title announcement, image flyout dashboards
paulinashakirova May 4, 2025
e806687
Merge branch 'main' into a11y-image-editor-flyout-title
paulinashakirova May 4, 2025
0813967
Merge branch 'main' into a11y-image-editor-flyout-title
paulinashakirova May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...m/plugins/private/image_embeddable/public/components/image_editor/image_editor_flyout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export function ImageEditorFlyout(props: ImageEditorFlyoutProps) {
<>
<EuiFlyoutHeader hasBorder={true}>
<EuiTitle size="s">
<h2>
<h2 id="image-editor-flyout-title">
{isEditing ? (
<FormattedMessage
id="imageEmbeddable.imageEditor.editImagetitle"
Expand Down
1 change: 1 addition & 0 deletions ...orm/plugins/private/image_embeddable/public/components/image_editor/open_image_editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export const openImageEditor = async ({
paddingSize: 'm',
ownFocus: true,
'data-test-subj': 'createImageEmbeddableFlyout',
'aria-labelledby': 'image-editor-flyout-title',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hard-coded here because I tried to pass using useGeneratedHtmld, but because the component is returned from a Promise (I think this could be the reason), it doesn't work correctly.
But maybe there is a better way?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly is issue? 🤔

}
);

Expand Down