Skip to content

[Fleet] Update spec.max to 3.4 #221544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025
Merged

[Fleet] Update spec.max to 3.4 #221544

merged 3 commits into from
Jun 10, 2025

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented May 26, 2025

Summary

Updates maximum supported spec version to 3.4.

3.4 spec version released in elastic/package-spec#896.

Intended to be released in 9.1, 8.19 and Serverless.

Common serverless settings are moved to the common file. spec.max is removed as it is the same as the default.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@jsoriano jsoriano self-assigned this May 26, 2025
@jsoriano jsoriano requested review from a team as code owners May 26, 2025 17:41
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label May 26, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jsoriano jsoriano added backport:prev-major Backport to (8.19, 8.18, 8.17) the previous major branch and other branches in development release_note:enhancement labels May 26, 2025
Copy link
Contributor

@jeramysoucy jeramysoucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock. Only question I had was already asked by Nicolas here

@jsoriano jsoriano requested a review from nchaulet May 27, 2025 14:40
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config changes LGTM. If possible, it's worth adding the ci:project-deploy-* labels to confirm in QA before merging to main.

@jsoriano jsoriano added ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project ci:project-deploy-observability Create an Observability project ci:project-deploy-security Create a Security Serverless Project ci:project-deploy-ai4soc Create an AI for SOC Security Serverless Project labels Jun 10, 2025
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@jsoriano
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 10, 2025

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @jsoriano

@jsoriano jsoriano added backport:version Backport to applied version labels and removed backport:prev-major Backport to (8.19, 8.18, 8.17) the previous major branch and other branches in development backport:version Backport to applied version labels labels Jun 10, 2025
@jsoriano jsoriano added backport:version Backport to applied version labels 8.19 candidate v8.19.0 labels Jun 10, 2025
@jsoriano jsoriano merged commit 25b5ff2 into elastic:main Jun 10, 2025
21 checks passed
@jsoriano jsoriano deleted the spec-max-3.4 branch June 10, 2025 14:38
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15562543091

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 221544

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 11, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 221544 locally
cc: @jsoriano

@jsoriano
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jsoriano added a commit that referenced this pull request Jun 12, 2025
# Backport

This will backport the following commits from `main` to `8.19`:
- [[Fleet] Update spec.max to 3.4
(#221544)](#221544)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Jaime Soriano
Pastor","email":"jaime.soriano@elastic.co"},"sourceCommit":{"committedDate":"2025-06-10T14:38:47Z","message":"[Fleet]
Update spec.max to 3.4 (#221544)\n\nUpdates maximum supported spec
version to 3.4.\n\n3.4 spec version released
in\nhttps://github.com/elastic/package-spec/pull/896.\n\nCommon
serverless settings are moved to the common
file.","sha":"25b5ff2b83fbfed6298babd640b67c41b732de94","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","backport
missing","Team:Fleet","ci:project-deploy-elasticsearch","ci:project-deploy-observability","ci:project-deploy-security","backport:version","8.19
candidate","v9.1.0","v8.19.0","ci:project-deploy-ai4soc"],"title":"[Fleet]
Update spec.max to
3.4","number":221544,"url":"https://github.com/elastic/kibana/pull/221544","mergeCommit":{"message":"[Fleet]
Update spec.max to 3.4 (#221544)\n\nUpdates maximum supported spec
version to 3.4.\n\n3.4 spec version released
in\nhttps://github.com/elastic/package-spec/pull/896.\n\nCommon
serverless settings are moved to the common
file.","sha":"25b5ff2b83fbfed6298babd640b67c41b732de94"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221544","number":221544,"mergeCommit":{"message":"[Fleet]
Update spec.max to 3.4 (#221544)\n\nUpdates maximum supported spec
version to 3.4.\n\n3.4 spec version released
in\nhttps://github.com/elastic/package-spec/pull/896.\n\nCommon
serverless settings are moved to the common
file.","sha":"25b5ff2b83fbfed6298babd640b67c41b732de94"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 12, 2025
nickpeihl pushed a commit to nickpeihl/kibana that referenced this pull request Jun 12, 2025
Updates maximum supported spec version to 3.4.

3.4 spec version released in
elastic/package-spec#896.

Common serverless settings are moved to the common file.
iblancof pushed a commit to iblancof/kibana that referenced this pull request Jun 16, 2025
Updates maximum supported spec version to 3.4.

3.4 spec version released in
elastic/package-spec#896.

Common serverless settings are moved to the common file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.19 candidate backport:version Backport to applied version labels ci:project-deploy-ai4soc Create an AI for SOC Security Serverless Project ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project ci:project-deploy-observability Create an Observability project ci:project-deploy-security Create a Security Serverless Project release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants