-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[Fleet] Update spec.max to 3.4 #221544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Update spec.max to 3.4 #221544
Conversation
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock. Only question I had was already asked by Nicolas here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Config changes LGTM. If possible, it's worth adding the ci:project-deploy-*
labels to confirm in QA before merging to main.
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
cc @jsoriano |
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15562543091 |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.19`: - [[Fleet] Update spec.max to 3.4 (#221544)](#221544) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jaime Soriano Pastor","email":"jaime.soriano@elastic.co"},"sourceCommit":{"committedDate":"2025-06-10T14:38:47Z","message":"[Fleet] Update spec.max to 3.4 (#221544)\n\nUpdates maximum supported spec version to 3.4.\n\n3.4 spec version released in\nhttps://github.com/elastic/package-spec/pull/896.\n\nCommon serverless settings are moved to the common file.","sha":"25b5ff2b83fbfed6298babd640b67c41b732de94","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","backport missing","Team:Fleet","ci:project-deploy-elasticsearch","ci:project-deploy-observability","ci:project-deploy-security","backport:version","8.19 candidate","v9.1.0","v8.19.0","ci:project-deploy-ai4soc"],"title":"[Fleet] Update spec.max to 3.4","number":221544,"url":"https://github.com/elastic/kibana/pull/221544","mergeCommit":{"message":"[Fleet] Update spec.max to 3.4 (#221544)\n\nUpdates maximum supported spec version to 3.4.\n\n3.4 spec version released in\nhttps://github.com/elastic/package-spec/pull/896.\n\nCommon serverless settings are moved to the common file.","sha":"25b5ff2b83fbfed6298babd640b67c41b732de94"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221544","number":221544,"mergeCommit":{"message":"[Fleet] Update spec.max to 3.4 (#221544)\n\nUpdates maximum supported spec version to 3.4.\n\n3.4 spec version released in\nhttps://github.com/elastic/package-spec/pull/896.\n\nCommon serverless settings are moved to the common file.","sha":"25b5ff2b83fbfed6298babd640b67c41b732de94"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Updates maximum supported spec version to 3.4. 3.4 spec version released in elastic/package-spec#896. Common serverless settings are moved to the common file.
Updates maximum supported spec version to 3.4. 3.4 spec version released in elastic/package-spec#896. Common serverless settings are moved to the common file.
Summary
Updates maximum supported spec version to 3.4.
3.4 spec version released in elastic/package-spec#896.
Intended to be released in 9.1, 8.19 and Serverless.
Common serverless settings are moved to the common file. spec.max is removed as it is the same as the default.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breaking
label should be applied in these situations.release_note:*
label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.