[APM][Unified Waterfall] Enable telemetry by removing unnecessary stopPropagation calls and updating data-test-subj attributes #229182
Conversation
iblancof
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
| if (hasToggle && onClick) { | ||
| e.stopPropagation(); |
There was a problem hiding this comment.
The problem of removing this is when we click on an item that has onClick, which typically opens a flyout, the accordion will close.
Screen.Recording.2025-07-23.at.15.23.01.mov
There was a problem hiding this comment.
I've slightly adjusted the logic for the accordion toggle so it's less intrusive to the content and removes the need to stop propagation. 425abaa
Let me know what you think.
Screen.Recording.2025-07-24.at.12.08.28.mov
...servability/plugins/apm/public/components/shared/trace_waterfall/toggle_accordion_button.tsx
Outdated
Show resolved
Hide resolved
…hared/trace_waterfall/toggle_accordion_button.tsx Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16529669704 |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
cc @iblancof |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Summary
Relates to #225472
While building the Unified Waterfall, part of the code was inspired by the APM waterfall, and there were some
e.stopPropagationcalls that were no longer needed and they were preventing the click event from reaching our EBT.To bring those events back and enable telemetry analysis on waterfall usage, the
e.stopPropagationcalls have been removed, and a fewdata-test-subjattributes have been renamed and/or added.A minor UI issue with the dependency field was also detected and fixed along the way.
How to test
FROM traces-*)