-
Notifications
You must be signed in to change notification settings - Fork 3.5k
update dockerfile template based on feedback from dockerhub #17794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
This pull request does not have a backport label. Could you fix it @jsvd? 🙏
|
|
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
apply feedback from docker-library/official-images#18983 (comment) - remove manual retries - decompress tarball without piping - determine architecture from within docker before downloading tarball - this is required for dockerhub - for wolfi based image keep the current injection of ARCH from the environment (cherry picked from commit 8e73c68)
apply feedback from docker-library/official-images#18983 (comment) - remove manual retries - decompress tarball without piping - determine architecture from within docker before downloading tarball - this is required for dockerhub - for wolfi based image keep the current injection of ARCH from the environment (cherry picked from commit 8e73c68)
…17801) apply feedback from docker-library/official-images#18983 (comment) - remove manual retries - decompress tarball without piping - determine architecture from within docker before downloading tarball - this is required for dockerhub - for wolfi based image keep the current injection of ARCH from the environment (cherry picked from commit 8e73c68) Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
…17800) apply feedback from docker-library/official-images#18983 (comment) - remove manual retries - decompress tarball without piping - determine architecture from within docker before downloading tarball - this is required for dockerhub - for wolfi based image keep the current injection of ARCH from the environment (cherry picked from commit 8e73c68) Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
apply feedback from docker-library/official-images#18983 (comment)