Skip to content

update dockerfile template based on feedback from dockerhub #17794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 11, 2025

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Jul 10, 2025

apply feedback from docker-library/official-images#18983 (comment)

  • remove manual retries
  • decompress tarball without piping
  • determine architecture from within docker before downloading tarball
    • this is required for dockerhub
    • for wolfi based image keep the current injection of ARCH from the environment

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

mergify bot commented Jul 10, 2025

This pull request does not have a backport label. Could you fix it @jsvd? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@jsvd jsvd marked this pull request as ready for review July 11, 2025 11:57
@jsvd jsvd added backport-9.0 Automated backport to the 9.0 branch with mergify backport-9.1 Automated backport to the 9.1 branch labels Jul 11, 2025
@jsvd jsvd self-assigned this Jul 11, 2025
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsvd jsvd merged commit 8e73c68 into elastic:main Jul 11, 2025
12 checks passed
mergify bot pushed a commit that referenced this pull request Jul 11, 2025
apply feedback from docker-library/official-images#18983 (comment)

- remove manual retries
- decompress tarball without piping
- determine architecture from within docker before downloading tarball
    - this is required for dockerhub
    - for wolfi based image keep the current injection of ARCH from the environment

(cherry picked from commit 8e73c68)
mergify bot pushed a commit that referenced this pull request Jul 11, 2025
apply feedback from docker-library/official-images#18983 (comment)

- remove manual retries
- decompress tarball without piping
- determine architecture from within docker before downloading tarball
    - this is required for dockerhub
    - for wolfi based image keep the current injection of ARCH from the environment

(cherry picked from commit 8e73c68)
jsvd added a commit that referenced this pull request Jul 11, 2025
…17801)

apply feedback from docker-library/official-images#18983 (comment)

- remove manual retries
- decompress tarball without piping
- determine architecture from within docker before downloading tarball
    - this is required for dockerhub
    - for wolfi based image keep the current injection of ARCH from the environment

(cherry picked from commit 8e73c68)

Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
@jsvd jsvd deleted the update_dockerfile_template branch July 11, 2025 12:51
jsvd added a commit that referenced this pull request Jul 11, 2025
…17800)

apply feedback from docker-library/official-images#18983 (comment)

- remove manual retries
- decompress tarball without piping
- determine architecture from within docker before downloading tarball
    - this is required for dockerhub
    - for wolfi based image keep the current injection of ARCH from the environment

(cherry picked from commit 8e73c68)

Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-9.0 Automated backport to the 9.0 branch with mergify backport-9.1 Automated backport to the 9.1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants