-
Notifications
You must be signed in to change notification settings - Fork 38
[connector/elasticapm] Add ability configure metric aggregation limit configs #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[connector/elasticapm] Add ability configure metric aggregation limit configs #626
Conversation
…anaged-server default values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments on the approach for the configurations.
… as only overflow attribute ++ Removed attributes from the exposed config
…e to only be applied at the resource level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one minor comment about putting configs in files in testadata directory which can be addressed in #698.
Thanks for sticking with this and apologies about the late review.
Exposed aggregation limit configs that are propagated to the
lsmintervalprocessor
.Note: I opted to keep the configuration names (
resource_limit
) the same as thelsmintervalprocessor
mostly so they are consistent for both components. Another option would be to restructure everything to omit the_limit
suffix soelasticapm::aggregation::limit::resource
andelasticapm::aggregation::limit::scope
. Let me know what you think.Checklist
connector/elasticapmconnector/README.md
to includes the limits in the example config.ymlapm-managed-service/checkout/apm-aggregation-service/config/config.go
Local Testing
make genelasticcol
local_test_1
,local_test_2
)telemetrygen traces --duration 1s --otlp-insecure --service "local_test_1"
Search for overflow metric documents with query
labels.overflow:true
to validate overflow behaviorExample Overflow metric
service map overflow
Reference
Closes : #465