Skip to content

log response body when webhook push fails #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2024
Merged

log response body when webhook push fails #106

merged 1 commit into from
Jul 5, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jul 5, 2024

Please take a look.

@efd6 efd6 self-assigned this Jul 5, 2024
@efd6 efd6 added the enhancement New feature or request label Jul 5, 2024
@efd6 efd6 force-pushed the log_push_errors branch from ffe3430 to d8389f5 Compare July 5, 2024 07:53
@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

kcreddy
kcreddy approved these changes Jul 5, 2024
View reviewed changes
Copy link

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some lint errors.
The change LGTM 👍🏼

@efd6
Copy link
Contributor Author

efd6 commented Jul 5, 2024

The lint complaints have no merit. The io.Copy cannot fail in a way that we can do anything with.

@efd6 efd6 merged commit bfadcc3 into elastic:main Jul 5, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @kcreddy