Skip to content

Conversation

greg-rychlewski
Copy link
Member

@greg-rychlewski greg-rychlewski commented Dec 24, 2022

Adds a small helper for people storing their execute migrations inside of files. Instead of

execute File.read!(file)
execute File.read!(file1), File.read!(file2)

it is

execute_file file
execute_file file1, file2

Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks great to me but I wonder if we need those to be integration tests. I think a unit test is fine, especially beacuse it builds on top of the already tested execute functionality?

@greg-rychlewski greg-rychlewski merged commit 84fe263 into elixir-ecto:master Dec 24, 2022
@greg-rychlewski
Copy link
Member Author

Makes sense. Thank you!

@greg-rychlewski greg-rychlewski deleted the execute_file branch February 7, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants