Skip all core tests that require MODULARIZE from being run in STRICT_JS mode. #24958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…JS mode, since the two are not compatible.
sbc100
approved these changes
Aug 18, 2025
There was a problem hiding this comment.
lgtm!
(Although I'm not sure its practical to ensure that all possible configs of the core test suite pass for all tests since there are so many and we/I tend to add new ones all the time without ensuring that all tests pass. Are you particularity interesting in the strict_js config?)
test/test_core.py
Outdated
| @@ -8025,6 +8027,7 @@ def get_wat_addr(call_index): | |||
| self.assertLessEqual(dwarf_addr, end_wat_addr) | |||
|
|
|||
| @no_modularize_instance('uses -sMODULARIZE') | |||
| @no_strict_js('This test verifies behavior in MODULARIZE mode, and STRICT_JS is not compatible with MODULARIZE') | |||
There was a problem hiding this comment.
This string can just be MODULARIZE is not compatible with STRICT_JS, which is the format we use elsewhere for this types of skips.
|
Yes, we are looking to "upgrade" to shipping with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip all core tests that require MODULARIZE from being run in STRICT_JS mode, since the two are not compatible.