Hack to recover from reading the wrong Fiber #33055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
|
Comparing: 0038c50...bbe62ec Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
rickhanlonii
approved these changes
Apr 29, 2025
| const newResetState = {}; | ||
| if (stateHook.next === null) { | ||
| // Hack alert. If formFiber is the workInProgress Fiber then |
|
🙏 |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 29, 2025
`requestFormReset` incorrectly tries to get the current dispatch queue from the Fiber. However, the Fiber might be the workInProgress which is an inconsistent state. This hack just tries the other Fiber if it detects one of the known inconsistent states but there can be more. Really we should stash the dispatch queue somewhere stateful which is effectively what `setState` does by binding it to the closure. DiffTrain build for [88b9767](88b9767)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 29, 2025
`requestFormReset` incorrectly tries to get the current dispatch queue from the Fiber. However, the Fiber might be the workInProgress which is an inconsistent state. This hack just tries the other Fiber if it detects one of the known inconsistent states but there can be more. Really we should stash the dispatch queue somewhere stateful which is effectively what `setState` does by binding it to the closure. DiffTrain build for [88b9767](88b9767)
This was referenced May 5, 2025
mattcarrollcode
added a commit
that referenced
this pull request
May 5, 2025
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
May 6, 2025
Test for facebook#30041 and facebook#33055 DiffTrain build for [79586c7](facebook@79586c7)
This was referenced May 6, 2025
This was referenced May 13, 2025
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestFormResetincorrectly tries to get the current dispatch queue from the Fiber. However, the Fiber might be the workInProgress which is an inconsistent state.This hack just tries the other Fiber if it detects one of the known inconsistent states but there can be more.
Really we should stash the dispatch queue somewhere stateful which is effectively what
setStatedoes by binding it to the closure.