Skip to content

issues fixed #33780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

issues fixed #33780

wants to merge 1 commit into from

Conversation

vaishcodescape
Copy link

Summary

This PR fixes critical issues with the React DevTools shell development environment that were preventing contributors from working on UI improvements and testing changes locally.
Problem: The DevTools shell was attempting to resolve React and related packages from a local build directory (build/oss-experimental), which caused module resolution errors and prevented the shell from running unless a full React build was present. This blocked UI development and local testing.
Solution:
Updated packages/react-devtools-shell/package.json to include react, react-dom, and react-is as direct dependencies
Modified packages/react-devtools-shell/webpack-server.js to resolve React packages from node_modules (npm versions) instead of the non-existent local build directory
This allows developers to run the DevTools shell immediately after yarn install without needing to build React from source

How did you test this change?

1. Forked repository and created branch from main

git checkout -b fix-devtools-shell-dependencies

2. Ran yarn in repository root

yarn install

3. Installed dependencies in DevTools shell package

cd packages/react-devtools-shell
yarn install

@facebook-github-bot
Copy link
Contributor

Hi @vaishcodescape!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@PingchuanMa has imported this pull request. If you are a Meta employee, you can view this in D78249405.

Copy link

@hardanishsingh1 hardanishsingh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants