Skip to content

Remove pluggable-libs submodule and cleanup (#433) #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PraveenMudalgeri
Copy link

Summary

This pull request removes the obsolete pluggable-libs submodule from the repository and cleans up all related references and documentation, as outlined in issue #433.


Changes Made

  • Deleted the pluggable-libs folder (already removed/skipped locally as it did not exist).
  • Removed the pluggable-libs entry from .gitmodules.
  • Removed all references to pluggable-libs from:
    • README.md
    • Other source files and documentation (found via recursive search).
  • Verified that linting and tests run cleanly without any errors.

Resolution

This PR fully resolves issue #433 by eliminating the deprecated submodule and all associated traces.

@faif
Copy link
Owner

faif commented Aug 2, 2025

Hi. The changes here are not addressing #433. Was the intention to refer to another issue?

@PraveenMudalgeri
Copy link
Author

Hi. The changes here are not addressing #433. Was the intention to refer to another issue?

Thank you for the review!

The initial commits in this PR (up to commit 06edbaa) fully address issue #433 by removing the pluggable-libs submodule and all related references.

The subsequent commits (7ec9916 and 3eb2663) are a follow-up to resolve CI failures we discovered when running the workflow after merging the cleanup (see PR #447). Those changes don’t introduce new behavior or patterns in the library—they simply sanitize the check_changes output so GitHub Actions can parse multi-file lists.

If you’d prefer, I can split the CI fix into a separate PR targeting the workflow alone. Otherwise, this combined PR ensures both the submodule cleanup and a green build on merge. Let me know which approach you’d prefer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants