build: workflows: Add a rules for denying incompatible types #10655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
requested review from
niedbalski,
patrick-stephens,
celalettin1286 and
fujimotos
as code owners
patrick-stephens
approved these changes
Jul 28, 2025
|
I recommend renaming the new option for clarity to |
Sounds good. I'll rename it later. |
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
This is because this behavior is default since gcc 14 or later. But our CI is still using ubuntu-22.04 as a base testing workers. So, we need to implement an additional task for denying incompatible types for pointer operations. Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
cosmo0920
force-pushed
the
cosmo0920-deny-incompatible-types
branch
from
9d7cc2d to
2e94779
Compare
edsiper
reviewed
Jul 30, 2025
CMakeLists.txt
Outdated
| @@ -436,6 +437,12 @@ if(FLB_COVERAGE) | |||
| set(CMAKE_BUILD_TYPE "Debug") | |||
| endif() | |||
|
|
|||
| if(FLB_COMPILER_STRICT_POINTER_TYPES) | |||
| if(CMAKE_C_COMPILER_ID MATCHES "GNU|Clang|AppleClang") | |||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror=incompatible-pointer-types") | |||
There was a problem hiding this comment.
maybe this is a bit cleaner: add_compile_options(-Wincompatible-pointer-types) (needs to be tested)
There was a problem hiding this comment.
I used as follows:
if(FLB_COMPILER_STRICT_POINTER_TYPES)
if(CMAKE_C_COMPILER_ID MATCHES "GNU|Clang|AppleClang")
add_compile_options(-Werror=incompatible-pointer-types)
endif()
# Currently, AppleClang has more struct rules when using -Werror=incompatible-pointer-types.
# We still permit to discarding const qualifiers warnings.
if(CMAKE_C_COMPILER_ID MATCHES "AppleClang")
add_compile_options(-Wno-incompatible-pointer-types-discards-qualifiers)
endif()
endif()Plus, AppleClang has more struct rules for incompatible pointer types.
Frequently, we discarded for constqualifiers so we still needed to permit this type on incompatibilities on macOS's toolchain.
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because this behavior is default since gcc 14 or later.
But our CI is still using ubuntu-22.04 as a base testing workers.
So, we need to implement an additional task for denying incompatible
types for pointer operations.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.