Skip to content

Merge pystandalone crypt and fallback on python RNG #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

twiggler
Copy link
Contributor

@twiggler twiggler commented Feb 18, 2025

This PR merges the logic in crypt.py of pystandalone with the mainline crypt.py.

Additionaly, when the pystandalone rng fails.
a fallback on the python cryptographic rng os.urandom is added

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.

Project coverage is 44.49%. Comparing base (c983d84) to head (25db239).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
acquire/crypt.py 52.38% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
- Coverage   44.51%   44.49%   -0.02%     
==========================================
  Files          26       26              
  Lines        3493     3508      +15     
==========================================
+ Hits         1555     1561       +6     
- Misses       1938     1947       +9     
Flag Coverage Δ
unittests 44.49% <52.38%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twiggler twiggler requested a review from Miauwkeru February 24, 2025 09:29
Add fallbacl when openssl crypto rng fails
@twiggler twiggler merged commit fdb9aaa into main Feb 24, 2025
21 of 22 checks passed
@twiggler twiggler deleted the consolidate-crypt branch February 24, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants