-
Notifications
You must be signed in to change notification settings - Fork 33
Rename OSX to macOS #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename OSX to macOS #228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe bump the dissect.target
dependency too?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
=======================================
Coverage 44.49% 44.49%
=======================================
Files 26 26
Lines 3508 3508
=======================================
Hits 1561 1561
Misses 1947 1947
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you look at fixing the docs test by any chance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind.
dbc17d8
to
dc53f0f
Compare
For discussion see fox-it/dissect.target#1085. Changelog should include the change of argument names as well.