Parquet IO: use dask pyarrow.dataset based engine instead of the legacy engine #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can we just bump requirements? We currently require a version from 6 Jun 2020. |
|
The current failure is actually not because of this PR, but so the Feather PR where I started using Checking this new class, it seems to be introduced in dask/dask#7415, which corresponds to dask 2021.05.0 |
martinfleis
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we were actually subclassing the legacy engine from dask, and not the newer pyarrow.dataset based one. This doesn't change anything for the rest in our code (all tests pass), and this should also get rid of a bunch of deprecation warnings (from pyarrow, from using the legacy APIs)
It might not yet be available for older dask versions, in which case I can add a fallback to subclass the legacy engine in that case.