Skip to content

Conversation

brendan-ward
Copy link
Member

@brendan-ward brendan-ward commented Nov 28, 2024

supersedes #498

Closes #500

@brendan-ward brendan-ward added this to the 0.11.0 milestone Nov 28, 2024
@jorisvandenbossche
Copy link
Member

So the fix of #496 for uv seems to not have been working for the release test builds (and they were also not tested on that PR because of the failing windows wheels .. although for the sdist test build it does work).

It seems that the ones that did work are running in a docker container, and so the uv set up on a plain github actions runner is still failing

@jorisvandenbossche
Copy link
Member

Hmm, it's bizarre that some environment fail doing the source .. (ubuntu, recent mac), but then when removing it seems that others (older mac) requires doing it for uv to work .. And Windows now also requires some activation step, which was before not needed.

We should maybe use the github action to install uv instead? (https://docs.astral.sh/uv/guides/integration/github/)
For the other places where we were using uv with a docker image that might not have been possible, but I think for this test-wheels job we should be able to use it?

@brendan-ward
Copy link
Member Author

Note: macos-latest is currently set to macos-14 and succeeds, whereas macos-12 is the older version and fails.

On macos-12, the install command for uv emits instructions to source it:

installing to /Users/runner/.local/bin
  uv
  uvx
everything's installed!

To add $HOME/.local/bin to your PATH, either restart your shell or run:

    source $HOME/.local/bin/env (sh, bash, zsh)
    source $HOME/.local/bin/env.fish (fish)

where as that instruction is omitted on macos-latest. Likewise, on windows-latest, it instructs us to set some environment variables:

Installing to C:\Users\runneradmin\.local\bin
  uv.exe
  uvx.exe
everything's installed!

To add C:\Users\runneradmin\.local\bin to your PATH, either restart your system or run:

    set Path=C:\Users\runneradmin\.local\bin;%Path%   (cmd)
    $env:Path = "C:\Users\runneradmin\.local\bin;$env:Path"   (powershell)

That said, it is certainly worth testing if the action will work better for all runners we're using here. Just pushed up a test of that.

@brendan-ward brendan-ward marked this pull request as ready for review November 29, 2024 18:14
@brendan-ward
Copy link
Member Author

Using the uv action worked! All was green prior to the final cleanup push.

@jorisvandenbossche jorisvandenbossche merged commit bbde6bb into main Nov 30, 2024
55 checks passed
@jorisvandenbossche jorisvandenbossche deleted the gdal_3.10.0 branch November 30, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: failure during parsing GDAL version number on windows during setup
2 participants