-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(node): Handle stack traces with data URI filenames #17218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
fcdb0ef
to
7072a48
Compare
c6b2471
to
59550e3
Compare
AbhiPrasad
approved these changes
Jul 30, 2025
Let's get this backported too! |
AbhiPrasad
pushed a commit
that referenced
this pull request
Aug 5, 2025
This PR copies what we did for Node (#17218) but for the Chromium stack parser.
RulaKhaled
pushed a commit
that referenced
this pull request
Aug 7, 2025
This PR copies what we did for Node (#17218) but for the Chromium stack parser.
Lms24
added a commit
that referenced
this pull request
Aug 7, 2025
…egration` (#17216) [#17218](#17218) adjusted data URI stack line parsing for most errors that go through the stack parsers (fully for node, line truncation in general). This patch now applies a similar logic to `globalHandlersIntegration` which in some conditions applies a stack frame that doesn't go through the same stack parser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
globalHandlersIntegration
#17216Because JavaScript can dynamically load code from text like this:
You can get slack lines like this:
These can be huge, often base64 encoded strings.
Currently we skip regex parsing on anything over 1k in length but that means we ignore the frame entirely.
This PR: