-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(astro): Streamline build logs #17301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this PR supposed to contain React Router and SolidStart changes as well?
oops, no, search and replace error ^^ |
); | ||
}); | ||
} else { | ||
logger.warn('Source map generation is disabled in your Astro configuration.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logger.warn('Source map generation is disabled in your Astro configuration.'); | |
logger.warn(`Source map generation is disabled in your Astro configuration (\`${settingKey}: false\`.`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to keep this extra compact, users can use debug: true for more information :)
This streamlines astro build logs in two ways:
debug: true
console.log
everywhere. This automatically prepends the message with@sentry/astro
, so no need for our own prefix there - see https://docs.astro.build/en/reference/integrations-reference/#astrointegrationloggersourceMaps: false
is explicitly set by a user, we always show a short warning, and a longer warning with more context whendebug: true