Add github PR template #902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
reviewed
Mar 23, 2017
|
|
||
| * [ ] If you've added code that should be tested, please add tests. | ||
| * [ ] If you've modified the API (e.g. added a new config or public method), update the [docs](https://github.com/getsentry/raven-js/tree/master/docs) and TypeScript [declaration file](/getsentry/raven-js/blob/master/typescript/raven.d.ts). | ||
| * [ ] Ensure your code lints and the test suite passes (npm test). |
There was a problem hiding this comment.
you don't need to worry about this, travis does it for you.
There was a problem hiding this comment.
I'd prefer people verify the tests locally before submitting a PR. Often people submit PRs, see Travis fails, then go "oh well" and never resolve the failures and leave the PR to stagnate – ends up being a waste of everyone's time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #859
cc @mattrobenolt @LewisJEllis @LucaVazz