Make fetch instrumentation grab Request.url when passed Request object #934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LewisJEllis
commented
Apr 14, 2017
| if (fetchInput.method) { | ||
| method = fetchInput.method; | ||
| } | ||
| } | ||
|
|
||
| if (args[1] && args[1].method) { |
There was a problem hiding this comment.
We do want to keep this here; in the case that both a Request object input and an init options object are passed, the init options object's method should override that of the Request object.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was previously assuming first argument to fetch was always a url string, which is not necessarily the case
Adds failing test and the fix; fixes #924.