Update ruby_whisper_params.c

[Olli]

Change param_names and values not to be references for rb_get_kwargs - so it can be compiled on ruby 3.3.6 and 3.4.1

[KitaitiMakoto]

Thanks for the pull request.

Can you show your environment and error logs? I tried Ruby 3.1 and 3.2 on my machine (macOS Apple Silicon) and Ubuntu Docker image but they compiled successfully.

And according to API reference, rb_get_kwargs function's second and fifth arguments (here, param_names and values respectively) should be references.

[Olli]

My setup is rvm with ruby 3.3.6 or 3.4.1
besides a lot of warnings here are the lines where the compiler stops:

ruby_whisper_params.c:921:26: error: passing argument 2 of ‘rb_get_kwargs’ from incompatible pointer type [-Wincompatible-pointer-types]
  921 |   rb_get_kwargs(kw_hash, &param_names, 0, RUBY_WHISPER_PARAMS_PARAM_NAMES_COUNT, &values);
      |                          ^~~~~~~~~~~~
      |                          |
      |                          ID (*)[30] {aka long unsigned int (*)[30]}
In file included from /home/xxx/.rvm/rubies/ruby-3.4.1/include/ruby-3.4.0/ruby/ruby.h:33:
/home/xxx/.rvm/rubies/ruby-3.4.1/include/ruby-3.4.0/ruby/internal/eval.h:380:49: note: expected ‘const ID *’ {aka ‘const long unsigned int *’} but argument is of type ‘ID (*)[30]’ {aka ‘long unsigned int (*)[30]’}
  380 | int rb_get_kwargs(VALUE keyword_hash, const ID *table, int required, int optional, VALUE *values);
      |                                       ~~~~~~~~~~^~~~~
ruby_whisper_params.c:921:82: error: passing argument 5 of ‘rb_get_kwargs’ from incompatible pointer type [-Wincompatible-pointer-types]
  921 |   rb_get_kwargs(kw_hash, &param_names, 0, RUBY_WHISPER_PARAMS_PARAM_NAMES_COUNT, &values);
      |                                                                                  ^~~~~~~
      |                                                                                  |
      |                                                                                  VALUE (*)[30] {aka long unsigned int (*)[30]}
/home/xxx/.rvm/rubies/ruby-3.4.1/include/ruby-3.4.0/ruby/internal/eval.h:380:91: note: expected ‘VALUE *’ {aka ‘long unsigned int *’} but argument is of type ‘VALUE (*)[30]’ {aka ‘long unsigned int (*)[30]’}
  380 | int rb_get_kwargs(VALUE keyword_hash, const ID *table, int required, int optional, VALUE *values);

If I change it like in the pull request than the compilation process works fine and whisper seem to also work as it supposed to.
I've also looked up the documentation. Because I didn't know why it works I've looked up in an LLM and ask why this works and it seems that it works because if you give an array to the function its automatically a reference to the first element of the array. Not sure if it's correct.

[KitaitiMakoto]

Ah, param_names and values are declared as arrays and it means they are pointers in C. You're right. My compiler (Homebrew clang version 20.1.2) is too smart to compile my wrong code.

Thank you!

[Olli]

thx for explanation :-) I'm getting smarter every day