Skip to content

ruby : test extra build options only when env var specified #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindings/ruby/ext/options.rb
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def missing_options
end

def extra_options
@options.keys + @pending_options - @ignored_options -
@options.keys + @pending_options + @ignored_options -
cmake_options.collect {|name, type, value| name}
end

Expand Down
7 changes: 1 addition & 6 deletions bindings/ruby/tests/test_package.rb
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,9 @@ def assert_installed(dir, version)
end

def test_build_options
# This test is disabled as it currently fails when run locally on macOS and
# Linux. We need to find a good way to handle the situation with build
# options which varies between platforms.
# Refs: https://github.com/ggml-org/whisper.cpp/pull/3132
omit "Temporarily disabled locally as this test currently fails when run locally" unless ENV["CI"]
options = BuildOptions::Options.new
assert_empty options.missing_options
unless ENV["CI"]
if ENV["TEST_EXTRA_OPTIONS"] == "1"
assert_empty options.extra_options
end
end
Expand Down
2 changes: 1 addition & 1 deletion bindings/ruby/whispercpp.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Gem::Specification.new do |s|
s.name = "whispercpp"
s.authors = ["Georgi Gerganov", "Todd A. Fisher"]
s.version = '1.3.2'
s.date = '2025-05-01'
s.date = '2025-05-11'
s.description = %q{High-performance inference of OpenAI's Whisper automatic speech recognition (ASR) model via Ruby}
s.email = 'todd.fisher@gmail.com'
s.extra_rdoc_files = ['LICENSE', 'README.md']
Expand Down
Loading