commands: make 4gb smudge warning show on all platforms #2507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That sounds like a great idea. I have a patch ready, but I'd rather put it in a separate PR so it makes it easier to generate the changelog. I gave this a shot in: #2510. |
technoweenie
approved these changes
Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request teaches the
git-lfs-smudge(1)andgit-lfs-filter-process(1)commands to display the 4gb object warning on all platforms, not justruntime.GOOS == "windows".In situations where multiple collaborators are working on a repository among different operating systems, it is useful for a contributor running macOS to know that he/she/they can potentially cause an issue for another collaborator running Windows when they commit a file larger than 4gb.
/cc @git-lfs/core
/cc #2459