Fix Bug: stop filtering events that contain function responses #2152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem?
As part of the preparation for an LLM call, the ADK will look through the session’s event list to create the LLM message history. As part of this, it filters out all events that don’t have any content or roles. Additionally, it will filter out any events that don’t have any text. Unfortunately, there are cases where there are events that just contain the
function_response
. These events are filtered mistakenly as well.How did we fix this problem?
We've updated the event filtering condition to cover events that contain
function_response
.How to reproduce this problem?
A sample script has been attached. It creates a user, llm and tool event. The tool is a simple function call that returns only the
function_response
. This event is filtered via ADK.Reproduce the bug