Skip to content

Migrate to docker/login-action for ghcr.io #4756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

codebien
Copy link
Contributor

@codebien codebien commented Apr 30, 2025

What?

It migrates the current docker login for ghcr.io registry to the shared docker/ action.

Why?

It reduces the code to maintain.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

@codebien codebien self-assigned this Apr 30, 2025
@codebien codebien force-pushed the use-login-action-ghcr branch from 34b23cd to 32c86f9 Compare April 30, 2025 13:36
@codebien codebien force-pushed the use-login-action-ghcr branch from 48e8086 to 42781a3 Compare May 8, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant