feat: Added ui feedback when adding type in typesync #512
+56
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmwhited
requested changes
Aug 25, 2025
There was a problem hiding this comment.
Appreciate you taking this task on!
Few things:
- make sure to format and lint your code
- I am not sure the typeRefs map and useEffect is the best way to scroll the newly added type into view. could just add the scroll into view in the
KnowledgeGraphBrowser.typeSelectedinstead. much less state to manage and theuseEffecthas me really worried
|
@cmwhited thank you for your feedback. I will work on it. |
|
@cmwhited |
what errors is it giving you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI Feedback when you added a new type from the left panel
Closes #498