Skip to content

binning_transform_params not working properly #355

@SandipKhaire

Description

@SandipKhaire

Hi,
I have observed that binning_transform_params defined for specific variable/attributes are getting applied to all remaining variables .i.e getting global default parameters updated and getting applied.
Ex.I have defined parameter for age variable binning_transform_params = {
'age':{'metric_missing':0.11,'metric_special':'empirical'}
} but when i run X_train_woe = binning_process.transform(X=testXX,metric='woe') and what i observed when printed in BinningProcess and _transform object tparams = {
"x": x,
"metric": metric,
"metric_special": metric_special,
"metric_missing": metric_missing,
"check_input": check_input,
"show_digits": show_digits
}
#print(tparams). and getting below parameters

Image

i think _transform method of the BinningProcess need to update with
Old
Image
With New

params = {}
if self.binning_transform_params is not None:
params = self.binning_transform_params.get(name, {})

metric_var = params.get("metric", metric)
metric_missing_var = params.get("metric_missing", metric_missing)
metric_special_var = params.get("metric_special", metric_special)

tparams = {
"x": x,
"metric": metric_var,
"metric_special": metric_special_var,
"metric_missing": metric_missing_var,
"check_input": check_input,
"show_digits": show_digits
}

Metadata

Metadata

Labels

bugSomething isn't working

Projects

Status

No status

Relationships

None yet

Development

No branches or pull requests

Issue actions