fix: Respect readonly settings #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
first of all: thank you for your work on this operator. It is very useful!
While testing it, I noticed that the operator does not respect the readOnly setting of the deploy key.
This means that even if the key is set to readOnly false, it will be created without write access.
This PR adds the readOnly setting to the create_key method and uses it when creating a new deploy key.
This way, the operator will respect the readOnly setting and create the deploy key with the correct permissions.
If you want to test it, I pushed a build to my repository that includes this change: ghcr.io/odit-services/github-deploy-key-operator/operator
I hope this helps and thank you again for your work on this operator!
Best regards,
Nicolai