Skip to content

Conversation

T0miii
Copy link

@T0miii T0miii commented Jan 10, 2024

Description

Responsive functionality was not working anymore

Fixes #51 (issue)

How Has This Been Tested?

Tested it by resising the Window and observing that the GridItems get placed on the correct position.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Owner

@gwinnem gwinnem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good.
All the formatting changes, makes me wonder if I need to update my
editor, esling and prettier config.

@gwinnem gwinnem merged commit 10514c3 into gwinnem:main Jan 10, 2024
@gwinnem gwinnem self-assigned this Jan 10, 2024
@gwinnem gwinnem added this to the Release 1.2.7 milestone Jan 10, 2024
@gwinnem gwinnem added the bug Something isn't working label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

option "responsive" not working
2 participants