fix: resolve critical equality issue in KeyComparator for index system #7623
+496
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
the
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- Fix fatal bug where different strings were incorrectly considered equal (e.g., '/upload/1.4.3.png' vs '/upload/1.4.6.png' returned 0) - Simplify implementation by removing complex decimal recognition logic - Remove version number pattern detection to avoid false positives - Maintain core numeric comparison functionality for integer segments - Preserve leading zero handling for proper string differentiation - Ensure index integrity and prevent data loss in production This change addresses a critical production safety issue where the index system could lose data due to incorrect string equality comparisons. Tests added: - KeyComparatorProductionSafetyTest: comprehensive production safety checks - KeyComparatorRiskAnalysisTest: edge case and risk assessment tests - Updated existing KeyComparatorTest with new test cases All 86 existing tests pass, confirming backward compatibility.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Fix fatal bug where different strings were incorrectly considered equal (e.g., '/upload/1.4.3.png' vs '/upload/1.4.6.png' returned 0)
Tests added:
Which issue(s) this PR fixes:
Fixes #7622
Does this PR introduce a user-facing change?