Skip to content

F aws workspacesweb portal #43444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

madhavvishnubhatta
Copy link
Contributor

@madhavvishnubhatta madhavvishnubhatta commented Jul 18, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Relations

Partially addresses #23489

References

Output from Acceptance Testing

% make testacc PKG=workspacesweb TESTS=TestAccWorkSpacesWebPortal TESTARGS="-parallel 3"  
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/workspacesweb/... -v -count 1 -parallel 20 -run='TestAccWorkSpacesWebPortal' -parallel 3 -timeout 360m -vet=off
2025/07/18 13:29:47 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/18 13:29:47 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccWorkSpacesWebPortal_tags
=== PAUSE TestAccWorkSpacesWebPortal_tags
=== RUN   TestAccWorkSpacesWebPortal_tags_null
=== PAUSE TestAccWorkSpacesWebPortal_tags_null
=== RUN   TestAccWorkSpacesWebPortal_tags_EmptyMap
=== PAUSE TestAccWorkSpacesWebPortal_tags_EmptyMap
=== RUN   TestAccWorkSpacesWebPortal_tags_AddOnUpdate
=== PAUSE TestAccWorkSpacesWebPortal_tags_AddOnUpdate
=== RUN   TestAccWorkSpacesWebPortal_tags_EmptyTag_OnCreate
=== PAUSE TestAccWorkSpacesWebPortal_tags_EmptyTag_OnCreate
=== RUN   TestAccWorkSpacesWebPortal_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccWorkSpacesWebPortal_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccWorkSpacesWebPortal_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccWorkSpacesWebPortal_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccWorkSpacesWebPortal_tags_DefaultTags_providerOnly
=== PAUSE TestAccWorkSpacesWebPortal_tags_DefaultTags_providerOnly
=== RUN   TestAccWorkSpacesWebPortal_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccWorkSpacesWebPortal_tags_DefaultTags_nonOverlapping
=== RUN   TestAccWorkSpacesWebPortal_tags_DefaultTags_overlapping
=== PAUSE TestAccWorkSpacesWebPortal_tags_DefaultTags_overlapping
=== RUN   TestAccWorkSpacesWebPortal_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccWorkSpacesWebPortal_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccWorkSpacesWebPortal_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccWorkSpacesWebPortal_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccWorkSpacesWebPortal_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccWorkSpacesWebPortal_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccWorkSpacesWebPortal_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccWorkSpacesWebPortal_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccWorkSpacesWebPortal_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccWorkSpacesWebPortal_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccWorkSpacesWebPortal_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccWorkSpacesWebPortal_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccWorkSpacesWebPortal_tags_ComputedTag_OnCreate
=== PAUSE TestAccWorkSpacesWebPortal_tags_ComputedTag_OnCreate
=== RUN   TestAccWorkSpacesWebPortal_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccWorkSpacesWebPortal_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccWorkSpacesWebPortal_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccWorkSpacesWebPortal_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccWorkSpacesWebPortal_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccWorkSpacesWebPortal_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccWorkSpacesWebPortal_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccWorkSpacesWebPortal_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccWorkSpacesWebPortal_basic
=== PAUSE TestAccWorkSpacesWebPortal_basic
=== RUN   TestAccWorkSpacesWebPortal_disappears
=== PAUSE TestAccWorkSpacesWebPortal_disappears
=== RUN   TestAccWorkSpacesWebPortal_update
=== PAUSE TestAccWorkSpacesWebPortal_update
=== RUN   TestAccWorkSpacesWebPortal_complete
=== PAUSE TestAccWorkSpacesWebPortal_complete
=== CONT  TestAccWorkSpacesWebPortal_tags
=== CONT  TestAccWorkSpacesWebPortal_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccWorkSpacesWebPortal_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccWorkSpacesWebPortal_tags_DefaultTags_emptyProviderOnlyTag (31.00s)
=== CONT  TestAccWorkSpacesWebPortal_disappears
--- PASS: TestAccWorkSpacesWebPortal_disappears (24.67s)
=== CONT  TestAccWorkSpacesWebPortal_complete
--- PASS: TestAccWorkSpacesWebPortal_tags_IgnoreTags_Overlap_DefaultTag (59.28s)
=== CONT  TestAccWorkSpacesWebPortal_update
--- PASS: TestAccWorkSpacesWebPortal_tags (85.49s)
=== CONT  TestAccWorkSpacesWebPortal_tags_DefaultTags_providerOnly
--- PASS: TestAccWorkSpacesWebPortal_complete (37.68s)
=== CONT  TestAccWorkSpacesWebPortal_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccWorkSpacesWebPortal_tags_DefaultTags_emptyResourceTag (29.02s)
=== CONT  TestAccWorkSpacesWebPortal_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccWorkSpacesWebPortal_tags_DefaultTags_updateToResourceOnly (34.88s)
=== CONT  TestAccWorkSpacesWebPortal_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccWorkSpacesWebPortal_tags_DefaultTags_providerOnly (80.77s)
=== CONT  TestAccWorkSpacesWebPortal_tags_DefaultTags_overlapping
--- PASS: TestAccWorkSpacesWebPortal_tags_DefaultTags_updateToProviderOnly (34.84s)
=== CONT  TestAccWorkSpacesWebPortal_tags_DefaultTags_nonOverlapping
--- PASS: TestAccWorkSpacesWebPortal_update (167.05s)
=== CONT  TestAccWorkSpacesWebPortal_tags_ComputedTag_OnCreate
--- PASS: TestAccWorkSpacesWebPortal_tags_DefaultTags_overlapping (65.34s)
=== CONT  TestAccWorkSpacesWebPortal_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccWorkSpacesWebPortal_tags_DefaultTags_nonOverlapping (60.44s)
=== CONT  TestAccWorkSpacesWebPortal_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccWorkSpacesWebPortal_tags_ComputedTag_OnCreate (29.44s)
=== CONT  TestAccWorkSpacesWebPortal_tags_EmptyTag_OnCreate
--- PASS: TestAccWorkSpacesWebPortal_tags_ComputedTag_OnUpdate_Replace (42.07s)
=== CONT  TestAccWorkSpacesWebPortal_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccWorkSpacesWebPortal_tags_ComputedTag_OnUpdate_Add (42.31s)
=== CONT  TestAccWorkSpacesWebPortal_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccWorkSpacesWebPortal_tags_EmptyTag_OnCreate (45.24s)
=== CONT  TestAccWorkSpacesWebPortal_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccWorkSpacesWebPortal_tags_DefaultTags_nullNonOverlappingResourceTag (24.05s)
=== CONT  TestAccWorkSpacesWebPortal_basic
--- PASS: TestAccWorkSpacesWebPortal_tags_EmptyTag_OnUpdate_Replace (52.28s)
=== CONT  TestAccWorkSpacesWebPortal_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccWorkSpacesWebPortal_basic (24.02s)
=== CONT  TestAccWorkSpacesWebPortal_tags_EmptyMap
--- PASS: TestAccWorkSpacesWebPortal_tags_EmptyTag_OnUpdate_Add (56.74s)
=== CONT  TestAccWorkSpacesWebPortal_tags_AddOnUpdate
--- PASS: TestAccWorkSpacesWebPortal_tags_EmptyMap (27.46s)
=== CONT  TestAccWorkSpacesWebPortal_tags_null
--- PASS: TestAccWorkSpacesWebPortal_tags_IgnoreTags_Overlap_ResourceTag (61.41s)
=== CONT  TestAccWorkSpacesWebPortal_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccWorkSpacesWebPortal_tags_AddOnUpdate (42.37s)
--- PASS: TestAccWorkSpacesWebPortal_tags_null (23.67s)
--- PASS: TestAccWorkSpacesWebPortal_tags_DefaultTags_nullOverlappingResourceTag (26.18s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/workspacesweb      413.695s

Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/workspacesweb Issues and PRs that pertain to the workspacesweb service. size/XL Managed by automation to categorize the size of a PR. partner Contribution from a partner. labels Jul 18, 2025
@madhavvishnubhatta madhavvishnubhatta force-pushed the f-aws_workspacesweb_portal branch from cf40e64 to 4072f14 Compare July 18, 2025 12:48
@madhavvishnubhatta madhavvishnubhatta marked this pull request as ready for review July 18, 2025 14:37
@madhavvishnubhatta madhavvishnubhatta requested a review from a team as a code owner July 18, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. service/workspacesweb Issues and PRs that pertain to the workspacesweb service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant