chore: improve error on dispatcher #1538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
internal/services/dispatcher/dispatcher_v1.go:233
- [nitpick] Consider renaming 'workerId' to 'workerID' to ensure consistency with common naming conventions.
fmt.Errorf("could not send action for task %s to worker %s (%d / %d): %w", sqlchelpers.UUIDToStr(task.ExternalID), workerId, i+1, len(workers), err),
grutt
approved these changes
Apr 15, 2025
grutt
added a commit
that referenced
this pull request
Apr 17, 2025
* simple trigger * populated * feat:trigger modal * clear * Update frontend/app/src/next/hooks/use-runs.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * wip activity log * merged logs * wip * wip * search box * fudge sort * wip improved worker sheet * wip * chore: improve error on dispatcher (#1538) * fix: empty billing context (#1553) * fix: empty * precommit * hotfix: priority nil pointer (#1555) * hotfix: priority on schedule workflow (#1556) * hotfix: priority on schedule workflow * fix: build * build * lint * build --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: abelanger5 <belanger@sas.upenn.edu>
grutt
added a commit
that referenced
this pull request
Apr 17, 2025
* chore: improve error on dispatcher (#1538) * fix: empty billing context (#1553) * fix: empty * precommit * hotfix: priority nil pointer (#1555) * hotfix: priority on schedule workflow (#1556) * hotfix: priority on schedule workflow * fix: build * Hotfix: Handle EOF Properly (#1557) * fix: handle EOF properly * chore: version * fix: debug logs * fix: rm eof type * hotfix: priority on cron workflow for v0 (#1558) * fix: one more possible null deref (#1560) * Hatchet Python Blog Post (#1526) * feat: initial pass at first parts of blog post * feat: initial mkdocs setup * feat: first pass at embedding mkdocs * fix: config * debug: paths * fix: unwind docs hack * feat: start working on mkdocs theme * fix: paths * feat: wrap up post * fix: proof * fix: doc links * fix: rm docs * fix: lint * fix: lint * fix: typos + tweak * fix: tweaks * fix: typo * fix: cleanup * fix: go signature and docs (#1561) * fix: go signature and docs * Update examples/v1/workflows/concurrency-rr.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: toggle doc sheet * docs: concurrency cleanup (#1562) * feat: storage adapter * docs--worker-config-options (#1535) * docs--worker-config-options * Update frontend/docs/pages/home/workers.mdx Co-authored-by: abelanger5 <belanger@sas.upenn.edu> * Update worker-configuration-options.mdx * lint --------- Co-authored-by: abelanger5 <belanger@sas.upenn.edu> --------- Co-authored-by: abelanger5 <belanger@sas.upenn.edu> Co-authored-by: Matt Kaye <mrkaye97@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
grutt
added a commit
that referenced
this pull request
May 5, 2025
* reintegration * fix: relative routes * dynamic routes * up/downgrade ui * memoize * fix breadcrumbs * cleanup * titles * title format * additional meta * cli upgrade * button * lint * Update frontend/app/src/next/components/runs/run-id.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * build errors * unbind on return * lint * Fe overhaul run form (#1547) * simple trigger * populated * feat:trigger modal * clear * Update frontend/app/src/next/hooks/use-runs.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fe overhaul details (#1552) * simple trigger * populated * feat:trigger modal * clear * Update frontend/app/src/next/hooks/use-runs.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * wip activity log * merged logs * wip * wip * search box * fudge sort * wip improved worker sheet * wip * chore: improve error on dispatcher (#1538) * fix: empty billing context (#1553) * fix: empty * precommit * hotfix: priority nil pointer (#1555) * hotfix: priority on schedule workflow (#1556) * hotfix: priority on schedule workflow * fix: build * build * lint * build --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: abelanger5 <belanger@sas.upenn.edu> * Fe overhaul burndown 1 (#1563) * chore: improve error on dispatcher (#1538) * fix: empty billing context (#1553) * fix: empty * precommit * hotfix: priority nil pointer (#1555) * hotfix: priority on schedule workflow (#1556) * hotfix: priority on schedule workflow * fix: build * Hotfix: Handle EOF Properly (#1557) * fix: handle EOF properly * chore: version * fix: debug logs * fix: rm eof type * hotfix: priority on cron workflow for v0 (#1558) * fix: one more possible null deref (#1560) * Hatchet Python Blog Post (#1526) * feat: initial pass at first parts of blog post * feat: initial mkdocs setup * feat: first pass at embedding mkdocs * fix: config * debug: paths * fix: unwind docs hack * feat: start working on mkdocs theme * fix: paths * feat: wrap up post * fix: proof * fix: doc links * fix: rm docs * fix: lint * fix: lint * fix: typos + tweak * fix: tweaks * fix: typo * fix: cleanup * fix: go signature and docs (#1561) * fix: go signature and docs * Update examples/v1/workflows/concurrency-rr.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: toggle doc sheet * docs: concurrency cleanup (#1562) * feat: storage adapter * docs--worker-config-options (#1535) * docs--worker-config-options * Update frontend/docs/pages/home/workers.mdx Co-authored-by: abelanger5 <belanger@sas.upenn.edu> * Update worker-configuration-options.mdx * lint --------- Co-authored-by: abelanger5 <belanger@sas.upenn.edu> --------- Co-authored-by: abelanger5 <belanger@sas.upenn.edu> Co-authored-by: Matt Kaye <mrkaye97@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: bit of spacing * single generated api * feat: initial styling pass on runs views (#1586) * Feat: Workflows pages (#1577) * feat: simple workflows list page * feat: refactor + add route for individual workflow * feat: start wiring up workflow detail page --------- Co-authored-by: Gabe Ruttner <gabriel.ruttner@gmail.com> * fix: tsc * fix: compiler * fe overhaul runs bash (#1599) * wip sidebar * wip: navigation * fix nits * tweaks * clear filter button * filter on click * always scroll y * wip time filters * state changes * wip * wip * functional, no style * fix default * wip * queue metrics * multi-select * padding * counts * fix always num * actions * fix maxheight * wip * spacing * fix: tenant state * fix: tenant * lint * github page * tenant alerting * ingestors * fix: tenant state * build errrors * empty state alerter * dropdown only on mobile * billing and limits * fix form * fix form * wip * wip * env vars * wip * what a component * wip * fix inf render * cleanup * persistent tabs * wip * common actions * deploy modal * update * delete * you're a wizard harry * Feat: Subrows in Runs View (#1595) * fix: type * feat: start wiring up subrows * fix: tsc * fix: hook order * fix: hack for tsc * fix: add some margin * fix: empty state * fix: empty state centering * fix: task detail links * fix: handle error, tweak child run styling * fix: lint * fix: edge case * all mw config * wip * fix breadcrumb hook * fixes * upgrade surfaces --------- Co-authored-by: Matt Kaye <mrkaye97@gmail.com> * bring back error toast * toast improvements * lint * fix: cloud only surface * cloud surface * fix breadcrumbs * feat: config view on workflow run page (#1607) * feat: config * fix: rm schedule timeout * Feat: Rework runs sidebar (#1612) * feat: rq devtools * fix: badge hover * feat: improve sidebar * refactor: hook * fix: input undefined * feat: waterfall diagram and cleanup runs view (#1606) * merge * merge * fix merge issue * rm debug lines * case on count * fix: display names * colors and handle on click --------- Co-authored-by: mrkaye97 <mrkaye97@gmail.com> * fix: remove a ton of dead code (#1618) * fix: remove n+1 query (#1619) * Fe overhaul managed compute and onboarding (#1614) * fix tab state on state changes * fix collapsed children * setup * layout * layout * move feature * wip * chore(deps): bump k8s.io/client-go from 0.32.3 to 0.33.0 (#1608) Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.32.3 to 0.33.0. - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.32.3...v0.33.0) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * wip * universal install * initial migration guide * fakefake tokens * fake secret * fixes * lint * lint * lint * tidy * chore: expose clean docs on top level * drop reo * wip * static * functional * bump go 1.23 -> 1.24 * fix: whitespace lint * bump golangci-lint version * wip * try to set up go before pre commit runs * lint * names * lint * fix: session store * wip * normalized snips * fix links * blog: mergent migration (#1611) * universal install * initial migration guide * fakefake tokens * fake secret * fixes * lint * lint * lint * tidy * bump go 1.23 -> 1.24 * fix: whitespace lint * bump golangci-lint version * try to set up go before pre commit runs * lint * names * lint * fix: session store * fix links --------- Co-authored-by: Alexander Belanger <alexander@hatchet.run> * reusable state * fix: rm unimplemented pages for now (#1615) * feature dir * fixes (#1616) * with public auth * completed typescript flow * go blocks * wip * layout * wip * feat: read replica support and docs (#1617) * feat: read replica support and docs * fix: load logic * wip * wip * remove provider * migrate to static * fix block * lint * fix: loadtest * add task for linting * cleanup * fix meta sync * clean examples with highlights * get snips into app * sync * remove fake highlights * always gen before build * ignore generated * ignore * ignore generated * cleanup * always start the dev server * examples dependabot * app examples built off sdk examples * auto sync on main changes * sync the quickstarts with updating dependencies * examples and quickstart dependabots * only examples * functional onboarding * fix worker detail page * fix detail page * lint * init * tested structure copy * prepend * ❓to >,‼️ to !! * normalize * separate example source * multi source * with index * wip * clean generation * migrated * cleanup * should build * sync before build * fix steps * inline * mkdirs * revert build * gen docs * static * rm * update examples * lint * fix: ts * fix remove lines on match * fix: client * add snips * dont lint examples * fix source * dont test examples * exclude quickstart * lint * dont break examples * cleanup * cleanup --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexander Belanger <alexander@hatchet.run> Co-authored-by: Matt Kaye <mrkaye97@gmail.com> Co-authored-by: abelanger5 <belanger@sas.upenn.edu> * Merge main * lint * fix * Update api-server-setup.mdx * cleanup * github state * review and build --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: abelanger5 <belanger@sas.upenn.edu> Co-authored-by: Matt Kaye <mrkaye97@gmail.com> Co-authored-by: Alexander Belanger <alexander@hatchet.run> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the error message coming from the dispatcher when we can't send a task to a worker.
Type of change