[WIP] Feat: Payload Store Repository #2047
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| task_id BIGINT NOT NULL, | ||
| task_inserted_at TIMESTAMPTZ NOT NULL, |
There was a problem hiding this comment.
unsure if this is a good idea or not - I was trying to think of cases where we'd want to tie payloads to non-task things but was struggling to think of any
| workflows: newWorkflowRepository(shared), | ||
| ticker: newTickerRepository(shared), | ||
| filters: newFilterRepository(shared), | ||
| payloadStore: shared.payloadStore, |
There was a problem hiding this comment.
I was pretty unhappy with this. The reason for it is we need to be able to access the payload store inside of the match repo, the tasks repo, the olap repo, etc., but we also need it on the dispatcher. Would love better ideas here, since I think this also will break the ability to override but I'm not sure about that
| } | ||
|
|
||
| func (p *payloadStoreRepositoryImpl) Store(ctx context.Context, tenantId string, payloads []StorePayloadOpts) error { | ||
| tx, commit, rollback, err := sqlchelpers.PrepareTx(ctx, p.pool, p.l, 5000) |
There was a problem hiding this comment.
basic idea here is we can change this to have any backend (e.g. S3 with a cache, etc.) so that we can plug whatever we need in. For S3, we might use e.g. taskId/taskInsertedAt/type.json as the key or something like that
mrkaye97
force-pushed
the
feat--external-payload-store
branch
from
94dd25c to
9e80a34
Compare
Description
WIP
Footguns / things to consider:
triggersfield in the payloads somehowType of change