-
Notifications
You must be signed in to change notification settings - Fork 163
fix: Fix ISS reporting mechanism #20370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20370 +/- ##
============================================
- Coverage 71.19% 71.16% -0.03%
- Complexity 24009 24073 +64
============================================
Files 2643 2648 +5
Lines 101860 102111 +251
Branches 10559 10606 +47
============================================
+ Hits 72515 72670 +155
- Misses 25396 25475 +79
- Partials 3949 3966 +17
... and 91 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
platform-sdk/swirlds-logging/src/main/java/com/swirlds/logging/legacy/payload/IssPayload.java
Outdated
Show resolved
Hide resolved
...k/swirlds-platform-core/src/main/java/com/swirlds/platform/state/iss/DefaultIssDetector.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Fixes #20304 #20326