Skip to content

fix: Fix ISS reporting mechanism #20370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2025
Merged

Conversation

thenswan
Copy link
Contributor

@thenswan thenswan commented Jul 25, 2025

Fixes #20304 #20326

Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
@lfdt-bot
Copy link

lfdt-bot commented Jul 25, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@thenswan thenswan self-assigned this Jul 25, 2025
@thenswan thenswan added this to the v0.65 milestone Jul 25, 2025
@thenswan thenswan added the Platform Tickets pertaining to the platform label Jul 25, 2025
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #20370      +/-   ##
============================================
- Coverage     71.19%   71.16%   -0.03%     
- Complexity    24009    24073      +64     
============================================
  Files          2643     2648       +5     
  Lines        101860   102111     +251     
  Branches      10559    10606      +47     
============================================
+ Hits          72515    72670     +155     
- Misses        25396    25475      +79     
- Partials       3949     3966      +17     
Files with missing lines Coverage Δ Complexity Δ
...com/swirlds/logging/legacy/payload/IssPayload.java 52.63% <ø> (+0.45%) 5.00 <0.00> (-1.00) ⬆️
...lds/platform/builder/PlatformComponentBuilder.java 70.11% <ø> (-0.09%) 87.00 <0.00> (ø)
...swirlds/platform/state/iss/DefaultIssDetector.java 78.04% <100.00%> (-0.32%) 39.00 <0.00> (ø)

... and 91 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

codacy-production bot commented Jul 25, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4af6b85) 101765 76419 75.09%
Head commit (9867a18) 101824 (+59) 76463 (+44) 75.09% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#20370) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Copy link
Contributor

@anthony-swirldslabs anthony-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@thenswan thenswan merged commit 2fec711 into main Jul 29, 2025
52 checks passed
@thenswan thenswan deleted the 20304-fix-iss-reporting-mechanism branch July 29, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Tickets pertaining to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ISS reporting mechanism
5 participants