Skip to content

Add muted and playsinline video attributes for HTML5. #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2021
Merged

Add muted and playsinline video attributes for HTML5. #949

merged 1 commit into from
Jun 30, 2021

Conversation

drichardson
Copy link
Contributor

Fix for video tag issues in #938.

Tested with this html file:

<!DOCTYPE html>
<html>
        <head>
                <meta charset="UTF-8">
                <title>Video Muted Attribute Test</title>
        </head>

        <body>
                <video autoplay loop muted playsinline>
                        <source src="video/Mine.mp4" type="video/mp4">
                </video>
        </body>
</html>

Testing Done

Before changes, the output was:

debian ~/code/tidy-html5 (next)$ build/cmake/tidy -quiet -errors test.html
line 9 column 17 - Warning: <video> proprietary attribute "muted"
line 9 column 17 - Warning: <video> proprietary attribute "playsinline"
debian ~/code/tidy-html5 (next)$ echo $?
1

After changes, the output was:

debian ~/code/tidy-html5 (add-muted)$ build/cmake/tidy -quiet -errors test.html
debian ~/code/tidy-html5 (add-muted)$ echo $?
0

@drichardson drichardson mentioned this pull request Jun 12, 2021
Closed
@balthisar balthisar closed this Jun 30, 2021
@balthisar
Copy link
Member

Closed and Reopening to force automated testing.

@balthisar balthisar reopened this Jun 30, 2021
@balthisar balthisar merged commit 6d9e98d into htacg:next Jun 30, 2021
@drichardson drichardson deleted the add-muted branch June 30, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drichardson @balthisar