Address deprecation in fromstring to frombuffer #1386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated since numpy 1.14 according to numpy/numpy#28254 This should be the correct fix for huggingface#1343 And after this is merged, one can likely just revert this huggingface#1351
|
was hoping that the tests could validate this code since I haven't tested it locally. marking this as draft for now. |
|
i guess the larger problem is that tensors could be bfloat16 or something like that. |
|
Seems like this code was taken from that moved from fromstring to frombuffer 2 months ago in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated since numpy 1.14 according to
numpy/numpy#28254
This should be the correct fix for #1343
And after this is merged, one can likely just revert this #1351