Skip to content

fix wrong animations in setGroupCurrent #11169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix wrong animations in setGroupCurrent #11169

wants to merge 4 commits into from
+25 −17

Conversation

MightyPlaza
Copy link
Contributor

on setGroupCurrent for fullscreen / maximized:

  • matches the windows alpha values
  • don't animate from the inactive border color
  • make the first frame have the proper window texture size (don't recalculate the monitor before turning fullscreen back on)

@MightyPlaza
use active window alpha on setGroupCurrent
8e084ca 
modified:   src/desktop/Window.cpp
@MightyPlaza
slightly improve m_realBorderColorPrevious changes
93b8c55 
modified:   src/Compositor.cpp
@MightyPlaza
remove mon recalc on fullscreen set and unset
e3bc03f 
modified:   src/Compositor.cpp
modified:   src/Compositor.hpp
modified:   src/desktop/Window.cpp
@vaxerski
Copy link
Member

c-f fails

@MightyPlaza
clang-format
294a6a5 
modified:   src/Compositor.hpp
@MightyPlaza
Copy link
Contributor Author

fixed

@vaxerski
Copy link
Member

just misses some tests. I think all of the bugs could be tested via having a dispatcher in the plugin to query props like the texture size color etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaxerski vaxerski vaxerski approved these changes

Assignees
No one assigned
Labels
core desktop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MightyPlaza @vaxerski