swipe: fix workspace swipe not rendering last frame if target ws is on edge #11184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n edge Fix for a weird behaviour that happens when swipe is only valid in 1 direction (i.e. from ws 1) When you start a swipe from the only direction possible, then swipe back (without releasing), the last frame where the delta is reset to 0 was not being rendered
vaxerski
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Fix for a weird behaviour that happens when swipe is only valid in 1
direction (i.e. from ws 1)
When you start a swipe from the only direction possible, then swipe back
(without releasing), the last frame where the delta is reset to 0 was
not being rendered
More detail and demonstration video in the bug report discussion
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Might deserve some testing for various
workspace_swipeconfigurations.Pleaso also try to reproduce the problem I'm trying to address (from master or any version) to check I'm not fixing a problem no one else has.
Is it ready for merging, or does it need work?
Ready to me, does fix the issue on my setup