Skip to content

Add HYPRLAND_NO_SD_VARS env condition #7358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Conversation

Vladimir-csp
Copy link
Contributor

Describe your PR, what does it fix/add?

Closes #7083. This was pretty simple.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Not sure if hardcoding systemctl & dbus-update-activation-environment stuff is really a good idea. Config would be more appropriate IMHO.

Especially the way dbus-update-activation-environment and the original dbus' environment works: it can not unset stuff.

Calling dbus-update-activation-environment with a bunch of already unset vars does literally nothing. From manpage:

VAR
... If VAR is not present in the environment, this argument is silently ignored.

The only cleanup option with original dbus is to export empty strings, and execute without --systemd.

And with dbus-broker there is no need for dbus-update-activation-environment at all, which begs for special treatment.

Is it ready for merging, or does it need work?

Patched my debian's hyprland 0.41.2, seems to work.

@github-actions github-actions bot added the core label Aug 15, 2024
@vaxerski vaxerski merged commit 682b30f into hyprwm:main Aug 16, 2024
10 checks passed
@Vladimir-csp
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable activation environment management
2 participants